Issue 160487: Fix or/|| mistake in ifdef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160487: Fix or/|| mistake in ifdef (Closed)

Created:
11 years, 4 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix or/|| mistake in ifdef TBR=mark BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22216

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 4 months ago (2009-08-01 03:27:29 UTC) #2

Too much Python, eh?  LGTM, of course.

Mark

On Fri, Jul 31, 2009 at 7:17 PM, <stuartmorgan@chromium.org> wrote:
> Reviewers: Mark Mentovai,
>
> Description:
> Fix or/|| mistake in ifdef
>
> TBR=3Dmark
> BUG=3Dnone
> TEST=3Dnone
>
> Committed: http://src.chromium.org/viewvc/chrome?view=3Drev&revision=3D22=
216
>
> Please review this at http://codereview.chromium.org/160487
>
> Affected files:
> =A0M chrome/browser/tab_contents/render_view_host_delegate_helper.cc
>
>
> Index: chrome/browser/tab_contents/render_view_host_delegate_helper.cc
> diff --git a/chrome/browser/tab_contents/render_view_host_delegate_helper=
.cc
> b/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
> index
> 0610f2531e1bd4bd4d26eaf0618b1238cdaf2981..1c1ca24ded65b1abd5bb8dfd8605d40=
4ae7e503b
> 100644
> --- a/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
> +++ b/chrome/browser/tab_contents/render_view_host_delegate_helper.cc
> @@ -155,7 +155,7 @@ WebPreferences
> RenderViewHostDelegateHelper::GetWebkitPrefs(
> =A0 =A0 web_prefs.web_security_enabled =3D
> =A0 =A0 =A0 =A0 !command_line.HasSwitch(switches::kDisableWebSecurity) &&
> =A0 =A0 =A0 =A0 prefs->GetBoolean(prefs::kWebKitWebSecurityEnabled);
> -#if defined(OS_WIN) or defined(OS_MACOSX)
> +#if defined(OS_WIN) || defined(OS_MACOSX)
> =A0 =A0 web_prefs.plugins_enabled =3D
> =A0 =A0 =A0 =A0 !command_line.HasSwitch(switches::kDisablePlugins) &&
> =A0 =A0 =A0 =A0 prefs->GetBoolean(prefs::kWebKitPluginsEnabled);
>
>
>

Expand Messages | Collapse Messages