Ever closer. Extract a client interface out of CrxInstaller and

chrome/browser/extensions/extension_install_ui.cc

Index: chrome/browser/extensions/extension_install_ui.cc
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
new file mode 100644
index 0000000000000000000000000000000000000000..796d5a7921cd3c7b4f1b19e8db082ca09eb86ec6
--- /dev/null
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -0,0 +1,99 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/extension_install_ui.h"
+
+#include "app/l10n_util.h"
+#include "grit/chromium_strings.h"
+#include "chrome/browser/browser_list.h"
+#include "chrome/browser/extensions/theme_preview_infobar_delegate.h"
+#include "chrome/browser/profile.h"
+#include "chrome/browser/tab_contents/tab_contents.h"
+
+#if defined(OS_WIN)
+#include "app/win_util.h"
+#elif defined(OS_MACOSX)
+#include "base/scoped_cftyperef.h"
+#include "base/sys_string_conversions.h"
+#include <CoreFoundation/CFUserNotification.h>
+#endif
+
+ExtensionInstallUI::ExtensionInstallUI(Profile* profile)
+    : profile_(profile), ui_loop_(MessageLoop::current()) {
+}
+
+bool ExtensionInstallUI::ConfirmInstall(Extension* extension) {
+  DCHECK(ui_loop_ == MessageLoop::current());
+
+  // We special-case themes to not show any confirm UI. Instead they are
+  // immediately installed, and then we show an infobar (see OnInstallSuccess)
+  // to allow the user to revert if they don't like it.
+  if (extension->IsTheme())
+    return true;
+
+#if defined(OS_WIN)
+  if (win_util::MessageBox(GetForegroundWindow(),
+          L"Are you sure you want to install this extension?\n\n"
+          L"You should only install extensions from sources you trust.",
+          l10n_util::GetString(IDS_PRODUCT_NAME).c_str(),
+          MB_OKCANCEL) != IDOK) {
+    return false;
+  }
+#elif defined(OS_MACOSX)
+  // Using CoreFoundation to do this dialog is unimaginably lame but will do
+  // until the UI is redone.
+  scoped_cftyperef<CFStringRef> product_name(
+      base::SysWideToCFStringRef(l10n_util::GetString(IDS_PRODUCT_NAME)));
+  CFOptionFlags response;
+  if (kCFUserNotificationAlternateResponse == CFUserNotificationDisplayAlert(
+      0, kCFUserNotificationCautionAlertLevel, NULL, NULL, NULL,
+      product_name,
+      CFSTR("Are you sure you want to install this extension?\n\n"
+           "This is a temporary message and it will be removed when "
+           "extensions UI is finalized."),
+      NULL, CFSTR("Cancel"), NULL, &response)) {
+    return false;
+  }
+#else
+  NOTREACHED();
+#endif  // OS_*
+
+  return true;
+}
+
+void ExtensionInstallUI::OnInstallSuccess(Extension* extension) {
+  if (extension->IsTheme()) {
+    Browser* browser = BrowserList::GetLastActiveWithProfile(profile_);
+    if (!browser)
+      return;
+
+    TabContents* tab_contents = browser->GetSelectedTabContents();
+    if (!tab_contents)
+      return;
+
+    tab_contents->AddInfoBar(new ThemePreviewInfobarDelegate(
+        tab_contents, extension->name()));
+  }
+}
+
+void ExtensionInstallUI::OnInstallFailure(const std::string& error) {
+  DCHECK(ui_loop_ == MessageLoop::current());
+
+#if defined(OS_WIN)
+  win_util::MessageBox(NULL, UTF8ToWide(error), L"Extension Install Error",
+      MB_OK | MB_SETFOREGROUND);
+#elif defined(OS_MACOSX)
+  // There must be a better way to do this, for all platforms.
+  scoped_cftyperef<CFStringRef> message_cf(
+      base::SysUTF8ToCFStringRef(error));
+  CFOptionFlags response;
+  CFUserNotificationDisplayAlert(
+      0, kCFUserNotificationCautionAlertLevel, NULL, NULL, NULL,
+      CFSTR("Extension Install Error"), message_cf,
+      NULL, NULL, NULL, &response);
+#else
+  LOG(ERROR) << error.c_str();

[Matt Perry, 2009/07/31 22:33:39]

nit: add a "Extension install failed:" prefix to this message

+  NOTREACHED();
+#endif
+}