Issue 160408: Make the Visual Studio /MP flag configurable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160408: Make the Visual Studio /MP flag configurable. (Closed)

Created:
11 years, 4 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
Mark Mentovai, bradn

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make the Visual Studio /MP flag configurable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22176

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	build/common.gypi	View		2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM. I'd ask bradnelson if setting VCCLCompilerTool's AdditionalOptions here would conflict with anything else that ...

11 years, 4 months ago (2009-07-30 19:17:25 UTC) #2

Aaron Boodman

+bradnelson Ok, I will wait for his feedback. On Thu, Jul 30, 2009 at 12:17 ...

11 years, 4 months ago (2009-07-30 19:19:46 UTC) #3

bradn

11 years, 4 months ago (2009-07-30 21:39:41 UTC) #4

LGTM

Actually, I have a pending gyp issue to add conditions on vstudio version and
32/64. Then we can auto-select this. But manual is certainly good to start. Can
you confirm that vs2008 works with this on? Does 32/64 play a role?

Expand Messages | Collapse Messages