net/socket/socks_client_socket_pool.h - Issue 1604042: Improve error messages for bad SocketParams.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_pool.h

Issue 1604042: Improve error messages for bad SocketParams. (Closed)

Patch Set: Address davidben's comments and add to gyp file. Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/socks_client_socket_pool.h

diff --git a/net/socket/socks_client_socket_pool.h b/net/socket/socks_client_socket_pool.h

index c202ce1c1066e702894d346473aa055036e55beb..b0b9b4b05fa1cb3389b49382f618059ef44fb175 100644

--- a/net/socket/socks_client_socket_pool.h

+++ b/net/socket/socks_client_socket_pool.h

@@ -188,7 +188,7 @@ class SOCKSClientSocketPool : public ClientSocketPool {

DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketPool);

};

-REGISTER_SOCKET_PARAMS_FOR_POOL(SOCKSClientSocketPool, SOCKSSocketParams)

+REGISTER_SOCKET_PARAMS_FOR_POOL(SOCKSClientSocketPool, SOCKSSocketParams);

} // namespace net

« no previous file with comments | « net/socket/client_socket_pool_base_unittest.cc ('k') | net/socket/tcp_client_socket_pool.h » ('j') | no next file with comments »