net/socket/socks_client_socket_pool.h - Issue 1604042: Improve error messages for bad SocketParams.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/socket/socks_client_socket_pool.h

Issue 1604042: Improve error messages for bad SocketParams. (Closed)

Patch Set: Address davidben's comments and add to gyp file. Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_	5 #ifndef NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_

6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_	6 #define NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_

7	7

8 #include <string>	8 #include <string>

9	9

10 #include "base/basictypes.h"	10 #include "base/basictypes.h"

(...skipping 170 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
181 NetLog* net_log_;	181 NetLog* net_log_;

182	182

183 DISALLOW_COPY_AND_ASSIGN(SOCKSConnectJobFactory);	183 DISALLOW_COPY_AND_ASSIGN(SOCKSConnectJobFactory);

184 };	184 };

185	185

186 PoolBase base_;	186 PoolBase base_;

187	187

188 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketPool);	188 DISALLOW_COPY_AND_ASSIGN(SOCKSClientSocketPool);

189 };	189 };

190	190

191 REGISTER_SOCKET_PARAMS_FOR_POOL(SOCKSClientSocketPool, SOCKSSocketParams)	191 REGISTER_SOCKET_PARAMS_FOR_POOL(SOCKSClientSocketPool, SOCKSSocketParams);

192	192

193 } // namespace net	193 } // namespace net

194	194

195 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_	195 #endif // NET_SOCKET_SOCKS_CLIENT_SOCKET_POOL_H_

OLD	NEW