Issue 1604031: Translate a few OpenGL ES values to OpenGL values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1604031: Translate a few OpenGL ES values to OpenGL values. (Closed)

Created:
10 years, 8 months ago by greggman

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Translate a few OpenGL ES values to OpenGL values. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44431

Patch Set 1 #

Total comments: 1

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -4 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		2 chunks	+20 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

10 years, 8 months ago (2010-04-13 16:46:05 UTC) #2

LGTM

http://codereview.chromium.org/1604031/diff/1/2
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

http://codereview.chromium.org/1604031/diff/1/2#newcode41
gpu/command_buffer/service/gles2_cmd_decoder.cc:41: // unit tests. For native
OpenGL ES 2.0 backend tese are not used. For OpenGL
tese -> these

Expand Messages | Collapse Messages