Issue 160393: X64: Add fix of issue 392 to X64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160393: X64: Add fix of issue 392 to X64 (Closed)

Created:
11 years, 4 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Add fix of issue 392 to X64 Committed: http://code.google.com/p/v8/source/detail?r=2594

Patch Set 4 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -9 lines)			Patch
M	src/x64/codegen-x64.cc	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/x64/disasm-x64.cc	View	1 2 3	6 chunks	+31 lines, -6 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/160393/diff/8/1004 File src/x64/disasm-x64.cc (right): http://codereview.chromium.org/160393/diff/8/1004#newcode262 Line 262: {"cmovbe", TWO_OPERANDS_INSTR, REG_OPER_OP_ORDER, false}, This one and ...

11 years, 4 months ago (2009-07-30 15:37:34 UTC) #2

William Hesse

11 years, 4 months ago (2009-08-03 09:03:50 UTC) #3

http://codereview.chromium.org/160393/diff/8/1004
File src/x64/disasm-x64.cc (right):

http://codereview.chromium.org/160393/diff/8/1004#newcode262
Line 262: {"cmovbe", TWO_OPERANDS_INSTR, REG_OPER_OP_ORDER, false},
On 2009/07/30 15:37:34, Lasse Reichstein wrote:
> This one and the next should be "cmova" and "cmovna", to follow the condition
> codes from conditional_code_suffix.

Done.  The conditional_code_suffix table was wrong.

http://codereview.chromium.org/160393/diff/8/1004#newcode267
Line 267: {"cmovnp", TWO_OPERANDS_INSTR, REG_OPER_OP_ORDER, false},
On 2009/07/30 15:37:34, Lasse Reichstein wrote:
> And parity is represented as "pe" and "po" (even/odd).
> 

Done.

Expand Messages | Collapse Messages

Issue 160393: X64: Add fix of issue 392 to X64 (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages