Make TOOLKIT_VIEWS port use views-based Autocomplete popup....

Make TOOLKIT_VIEWS port use views-based Autocomplete popup.

The popups now interact with the edit via AutocompleteEditView rather than the platform-specific types.

Note this also removes the old omnibox popup code. It hasn't been active for some time.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22168

[sky, 2009-07-30 23:02:38]

Should also remove chrome_switches::kDisableOmnibox2 along with anything hidden
behind it?

http://codereview.chromium.org/160378/diff/230/232
File chrome/browser/autocomplete/autocomplete_popup_view.h (right):

http://codereview.chromium.org/160378/diff/230/232#newcode22
Line 22: #if defined(OS_WIN) || defined(OS_LINUX)
Should this be TOOLKIT_VIEWS? I'm fine with this, just as long as it doesn't
break chromeos builds.

http://codereview.chromium.org/160378/diff/230/232#newcode61
Line 61: #if defined(OS_WIN) || defined(OS_LINUX)
Same comment for this one.

[Ben Goodger (Google), 2009-07-30 23:30:49]

Assuming CHROMEOS == !TOOLKIT_VIEWS && OS_LINUX then yes this should
be fine (I built and tested non-toolkit_views Linux chrome).

Snapshot updated to include removing the switch.

-Ben

On Thu, Jul 30, 2009 at 4:02 PM, <sky@chromium.org> wrote:
>
> Should also remove chrome_switches::kDisableOmnibox2 along with anything
> hidden behind it?
>
>
> http://codereview.chromium.org/160378/diff/230/232
> File chrome/browser/autocomplete/autocomplete_popup_view.h (right):
>
> http://codereview.chromium.org/160378/diff/230/232#newcode22
> Line 22: #if defined(OS_WIN) || defined(OS_LINUX)
> Should this be TOOLKIT_VIEWS? I'm fine with this, just as long as it
> doesn't break chromeos builds.
>
> http://codereview.chromium.org/160378/diff/230/232#newcode61
> Line 61: #if defined(OS_WIN) || defined(OS_LINUX)
> Same comment for this one.
>
> http://codereview.chromium.org/160378
>

[sky, 2009-07-31 17:12:44]

LGTM