Issue 160191: Move base::va_copy from a function to a macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160191: Move base::va_copy from a function to a macro. (Closed)

Created:
11 years, 5 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, brettw

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move base::va_copy from a function to a macro. va_copy is a builtin, you can't just pass it references like we did previously.

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -11 lines)			Patch
M	base/port.h	View	1 chunk	+2 lines, -8 lines	1 comment	Download
M	base/string_util.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/string_util_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

lgtm http://codereview.chromium.org/160191/diff/1/2 File base/port.h (right): http://codereview.chromium.org/160191/diff/1/2#newcode42 Line 42: #define GG_VA_COPY(a, b) (::va_copy(a, b)) You don't ...

11 years, 5 months ago (2009-07-27 21:07:30 UTC) #2

brettw

11 years, 5 months ago (2009-07-27 21:09:49 UTC) #3

LGTM

On Mon, Jul 27, 2009 at 2:07 PM, <mark@chromium.org> wrote:
> lgtm
>
>
> http://codereview.chromium.org/160191/diff/1/2
> File base/port.h (right):
>
> http://codereview.chromium.org/160191/diff/1/2#newcode42
> Line 42: #define GG_VA_COPY(a, b) (::va_copy(a, b))
> You don't need the :: any longer.
>
> http://codereview.chromium.org/160191
>

Expand Messages | Collapse Messages