Issue 160020: Cleanup pending tasks under Valgrind as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160020: Cleanup pending tasks under Valgrind as well. (Closed)

Created:
11 years, 5 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Cleanup pending tasks under Valgrind as well. BUG=16095 Committed: http://src.chromium.org/viewvc/21429

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -6 lines)			Patch
	M	base/message_loop.cc	View		2 chunks	+10 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik does not do reviews

http://codereview.chromium.org/160020/diff/1/2 File base/message_loop.cc (right): http://codereview.chromium.org/160020/diff/1/2#newcode375 Line 375: #if defined(PURIFY) can these conditionals just be changed ...

11 years, 5 months ago (2009-07-23 17:48:26 UTC) #2

kuchhal

RUNNING_ON_VALGRIND macro is only defined on linux/mac through valgrind.h header. Moreever we actually need to ...

11 years, 5 months ago (2009-07-23 17:59:34 UTC) #3

Erik does not do reviews

11 years, 5 months ago (2009-07-23 19:48:01 UTC) #4

Ah, right.  I was reading that if (RUNNING_ON_VALGRIND) as #if.

LGTM

Expand Messages | Collapse Messages