Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1599038: Revert 44885 - Select and close previous theme info bars when resetting to de... (Closed)

Created:
10 years, 8 months ago by jorlow
Modified:
9 years, 6 months ago
Reviewers:
jorlow
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 44885 - Select and close previous theme info bars when resetting to default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well. BUG=35607 TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry) Landing http://codereview.chromium.org/1622017/show for Satish. Review URL: http://codereview.chromium.org/1600030 TBR=jorlow@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44886

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -138 lines) Patch
M chrome/browser/automation/automation_provider.h View 2 chunks +0 lines, -4 lines 0 comments Download
MM chrome/browser/automation/automation_provider.cc View 4 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.h View 3 chunks +1 line, -18 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 2 chunks +4 lines, -31 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/test/automation/automation_proxy.h View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/test/automation/extension_proxy_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 chunk +1 line, -1 line 0 comments Download
D chrome/test/ui/infobars_uitest.cc View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jorlow
10 years, 8 months ago (2010-04-18 08:29:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698