Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 1600030: Select and close previous theme info bars when resetting to default theme via... (Closed)

Created:
10 years, 8 months ago by jorlow
Modified:
9 years, 6 months ago
Reviewers:
Satish
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Select and close previous theme info bars when resetting to default theme via the options dialog. As a nice side effect if one tab is showing a theme info bar and the user switches to a different theme in another tab, this change closes the previous theme info bars as well. BUG=35607 TEST=Install a theme, and with the theme info bar visible open Preferences dialog and click 'reset to default theme' and check the info bar. (full steps given in the above bug entry) Landing http://codereview.chromium.org/1622017/show for Satish. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44885

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -19 lines) Patch
M chrome/browser/automation/automation_provider.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.h View 3 chunks +18 lines, -1 line 0 comments Download
M chrome/browser/extensions/theme_installed_infobar_delegate.cc View 2 chunks +31 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/automation/automation_messages_internal.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/automation/automation_proxy.h View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/test/automation/automation_proxy.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/test/automation/extension_proxy_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/pyautolib/pyautolib.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/pyautolib.i View 1 chunk +1 line, -1 line 0 comments Download
A chrome/test/ui/infobars_uitest.cc View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jorlow
10 years, 8 months ago (2010-04-16 22:39:31 UTC) #1
jorlow
10 years, 8 months ago (2010-04-16 23:06:11 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698