Re-enable the grit hook, and make it more solid in case of failures....

Re-enable the grit hook, and make it more solid in case of failures.

I was unable to reproduce the failures from the bots on my machine.

If they appear again, the build will not break, ane we will get full info.

TEST=none
http://crbug.com/17706

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22480

[Paweł Hajdan Jr., 2009-08-04 18:51:30]

It should not explode now. I tested even the previous version on my machine - no
problems. I also tested this new version, which should not break the buildbots
this time.

Well, at least not in the same way. :(

[Nicolas Sylvain, 2009-08-04 19:17:45]

LGTM, this is scary though

I found feel a lot more comfortable if you could submit this
later at night or early in the morning.. just in case

Nicolas

[Paweł Hajdan Jr., 2009-08-04 19:21:18]

Yeah, but the build break will be triggered by change to .grd files, not
just committing the hook. I won't commit it right now, but do you have a
good coordination plan? If I commit late today, someone will update grds
tomorrow and the tree will break unexpectedly.

On Tue, Aug 4, 2009 at 12:17, <nsylvain@chromium.org> wrote:

> LGTM, this is scary though
>
> I found feel a lot more comfortable if you could submit this
> later at night or early in the morning.. just in case
>
> Nicolas
>
>
>
> http://codereview.chromium.org/159866
>

[bradn, 2009-08-04 19:25:16]

LGTM

[Nicolas Sylvain, 2009-08-04 21:26:41]

On Tue, Aug 4, 2009 at 12:20 PM, Pawe=C5=82 Hajdan Jr.
<phajdan.jr@chromium.org>wrote:

> Yeah, but the build break will be triggered by change to .grd files, not
> just committing the hook. I won't commit it right now, but do you have a
> good coordination plan? If I commit late today, someone will update grds
> tomorrow and the tree will break unexpectedly.


You can make a dummy change in a grd. of a major change in the grd and send
it to the  try server.

Nicolas


>
> On Tue, Aug 4, 2009 at 12:17, <nsylvain@chromium.org> wrote:
>
>> LGTM, this is scary though
>>
>> I found feel a lot more comfortable if you could submit this
>> later at night or early in the morning.. just in case
>>
>> Nicolas
>>
>>
>>
>> http://codereview.chromium.org/159866
>>
>
>

[fta, 2009-08-05 14:10:45]

http://codereview.chromium.org/159866/diff/1/2
File DEPS (right):

http://codereview.chromium.org/159866/diff/1/2#newcode141
Line 141: "action": ["python", "src/build/win/clobber_generated_headers.py",
"$matching_files"],
shouldn't this be OS specific?

[Paweł Hajdan Jr., 2009-08-05 15:31:12]

On Wed, Aug 5, 2009 at 07:10, <fta@sofaraway.org> wrote:

>
> http://codereview.chromium.org/159866/diff/1/2
> File DEPS (right):
>
> http://codereview.chromium.org/159866/diff/1/2#newcode141
> Line 141: "action": ["python",
> "src/build/win/clobber_generated_headers.py", "$matching_files"],
> shouldn't this be OS specific?


The script checks if it's being run on Windows... I'm not sure if there can
be OS-specific hooks in DEPS file. If so, then yes, it should be.

For now the biggest trouble is making this hook not explode on Windows.
Today it's try #2.