Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 159859: linux: use linux-specific window control graphics from glen (Closed)

Created:
11 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, Glen Murphy
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: use linux-specific window control graphics from glen BUG=15952, 18385

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M app/resources/app_resources.grd View 1 chunk +36 lines, -19 lines 2 comments Download
M app/resources/linux_close.png View 0 chunks +-1 lines, --1 lines 0 comments Download
app/resources/linux_close_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_close_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_close_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_controls.psd View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_maximize.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_maximize_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_maximize_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
app/resources/linux_maximize_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_minimize.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_minimize_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_minimize_mask.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_minimize_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_restore.png View 0 chunks +-1 lines, --1 lines 0 comments Download
app/resources/linux_restore_h.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A app/resources/linux_restore_p.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/gtk/browser_titlebar.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Martin
no tricks this time, just checking in the files glen sent
11 years, 4 months ago (2009-08-04 17:06:37 UTC) #1
tony
LGTM, just 2 nits http://codereview.chromium.org/159859/diff/1/2 File app/resources/app_resources.grd (right): http://codereview.chromium.org/159859/diff/1/2#newcode15 Line 15: <if expr="os == 'windows'"> ...
11 years, 4 months ago (2009-08-04 17:11:09 UTC) #2
Glen Murphy
You also don't need to check the PSD file in.
11 years, 4 months ago (2009-08-04 17:16:32 UTC) #3
Evan Martin
On 2009/08/04 17:16:32, Glen Murphy wrote: > You also don't need to check the PSD ...
11 years, 4 months ago (2009-08-04 17:19:44 UTC) #4
Glen Murphy
They might. In the past we've put these files up on dev.chromium.org (there are no ...
11 years, 4 months ago (2009-08-04 17:25:51 UTC) #5
Evan Martin
11 years, 4 months ago (2009-08-04 17:26:12 UTC) #6
On 2009/08/04 17:25:51, Glen Murphy wrote:
> They might. In the past we've put these files up on dev.chromium.org
> (there are no PSDs in our source tree), assuming that designers
> shouldn't have to/won't want to bother with svn, and that engineers
> don't want to have to pull down 100s of MBs of PSDs. However, that
> might be just a generalization that doesn't apply to Linux, so feel
> free to check them in, though it feels a little strange putting them
> in the same place as the output images.

Ok, I won't rock the boat on this one.  Gone.
(Running through mac/win trybots now...)

Powered by Google App Engine
This is Rietveld 408576698