Issue 159827: Fix infinite loop in grit headers clobbering script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159827: Fix infinite loop in grit headers clobbering script. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
tony, Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Fix infinite loop in grit headers clobbering script. It turns out that on Windows the path-splitting function will always preserve the drive part (c:\). TEST=none http://crbug.com/17706 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22344

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/win/clobber_generated_headers.py	View		2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

lgtm