Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: build/win/clobber_generated_headers.py

Issue 159827: Fix infinite loop in grit headers clobbering script. (Closed)
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/win/clobber_generated_headers.py
diff --git a/build/win/clobber_generated_headers.py b/build/win/clobber_generated_headers.py
index 7b90b37927c286e10544e4fc7eb87f9787405ec6..cfcf83b831e5576fc190076883a03f074a5736a4 100644
--- a/build/win/clobber_generated_headers.py
+++ b/build/win/clobber_generated_headers.py
@@ -22,6 +22,8 @@ def total_split(path):
components = []
while path:
head, tail = os.path.split(path)
+ if not tail:
+ break
components.append(tail)
path = head
return list(reversed(components))
@@ -46,4 +48,4 @@ for path in sys.argv[1:]:
os.remove(full_path)
print 'Clobbered ' + full_path
except OSError:
- print 'Could not remove ' + full_path + '. Continuing.'
+ print 'Could not remove ' + full_path + '. Continuing.'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698