Issue 159751: Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on shut...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159751: Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on shut... (Closed)

Created:
11 years, 4 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on shutdown due to a check in OwnedWidgetGtk for unbalanced refcnt. The NativeViewHostGtk now owns the GtkWidget attached to it for the lifetime of its attachment. This removes my crazy ownership games from before and makes it a lot simpler. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22230

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -16 lines)			Patch
M	chrome/browser/views/location_bar_view.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	views/controls/native/native_view_host_gtk.h	View	1	2 chunks	+6 lines, -4 lines	1 comment	Download
M	views/controls/native/native_view_host_gtk.cc	View	1	5 chunks	+12 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jcampan

11 years, 4 months ago (2009-07-31 23:51:56 UTC) #2

LGTM

http://codereview.chromium.org/159751/diff/1002/11
File views/controls/native/native_view_host_gtk.h (right):

http://codereview.chromium.org/159751/diff/1002/11#newcode49
Line 49: // DestroyFixed returns true if an associated GtkWidget was addref'ed.
It does not return anything anymore, fix comment.

Expand Messages | Collapse Messages