Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7554)

Unified Diff: chrome/browser/views/location_bar_view.cc

Issue 159751: Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on shut... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/location_bar_view.cc
===================================================================
--- chrome/browser/views/location_bar_view.cc (revision 22173)
+++ chrome/browser/views/location_bar_view.cc (working copy)
@@ -130,6 +130,12 @@
}
LocationBarView::~LocationBarView() {
+#if defined(OS_LINUX)
+ // We must release the ref that the NativeViewHost has on the
+ // AutocompleteEditViewGtk, otherwise its internal OwnedWidgetGtk will
+ // complain about its refcount not being 1 as it is destroyed.
+ location_entry_view_->Detach();
+#endif
DeletePageActionViews();
}
« no previous file with comments | « no previous file | views/controls/native/native_view_host_gtk.h » ('j') | views/controls/native/native_view_host_gtk.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698