Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 159735: Removes an unused function in clipboard_linux as well as unused method... (Closed)

Created:
11 years, 4 months ago by sky
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Removes an unused function in clipboard_linux as well as unused method declaration. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M base/clipboard.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/clipboard_linux.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sky
11 years, 4 months ago (2009-07-31 22:02:01 UTC) #1
Evan Stade
11 years, 4 months ago (2009-07-31 22:06:51 UTC) #2
On Fri, Jul 31, 2009 at 3:02 PM, <sky@chromium.org> wrote:
> Reviewers: Evan Stade,
>
> Description:
> Removes an unused function in clipboard_linux as well as unused method
> declaration.
>
> BUG=3Dnone
> TEST=3Dnone
>
>
> Please review this at http://codereview.chromium.org/159735
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 base/clipboard.h
> =A0M =A0 =A0 base/clipboard_linux.cc
>
>
> Index: base/clipboard_linux.cc
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- base/clipboard_linux.cc =A0 =A0 (revision 22158)
> +++ base/clipboard_linux.cc =A0 =A0 (working copy)
> @@ -83,22 +83,6 @@
> =A0 delete map;
> =A0}
>
> -// Frees the pointers in the given map and clears the map.
> -// Does not double-free any pointers.
> -void FreeTargetMap(Clipboard::TargetMap map) {
> - =A0std::set<char*> ptrs;
> -
> - =A0for (Clipboard::TargetMap::iterator iter =3D map.begin();
> - =A0 =A0 =A0 iter !=3D map.end(); ++iter)
> - =A0 =A0ptrs.insert(iter->second.first);
> -
> - =A0for (std::set<char*>::iterator iter =3D ptrs.begin();
> - =A0 =A0 =A0 iter !=3D ptrs.end(); ++iter)
> - =A0 =A0delete[] *iter;
> -
> - =A0map.clear();
> -}
> -
> =A0// Called on GdkPixbuf destruction; see WriteBitmap().
> =A0void GdkPixbufFree(guchar* pixels, gpointer data) {
> =A0 free(pixels);
> Index: base/clipboard.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- base/clipboard.h =A0 =A0(revision 22158)
> +++ base/clipboard.h =A0 =A0(working copy)
> @@ -193,8 +193,6 @@
>
> =A0 // Write changes to gtk clipboard.
> =A0 void SetGtkClipboard();
> - =A0// Free pointers in clipboard_data_ and clear() the map.
> - =A0void FreeTargetMap();
> =A0 // Insert a mapping into clipboard_data_.
> =A0 void InsertMapping(const char* key, char* data, size_t data_len);
>
>
>
>

lgtm

Powered by Google App Engine
This is Rietveld 408576698