Making /MP on by default for msvs2008.

Making /MP on by default for msvs2008.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22220

[Peter Kasting, 2009-07-31 22:04:45]

http://codereview.chromium.org/159732/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/159732/diff/1/2#newcode110
Line 110: ['MSVS_VERSION=="2008"', {
Nit: I suggest reversing the conditional, so we turn things off for 2005 and on
otherwise.  This way you won't need to update this line for VS 2010 (and later).

[Aaron Boodman, 2009-07-31 22:05:04]

LGTM

[bradn, 2009-07-31 22:13:00]

http://codereview.chromium.org/159732/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/159732/diff/1/2#newcode110
Line 110: ['MSVS_VERSION=="2008"', {
On 2009/07/31 22:04:45, Peter Kasting wrote:
> Nit: I suggest reversing the conditional, so we turn things off for 2005 and
on
> otherwise.  This way you won't need to update this line for VS 2010 (and
later).

Good point. Done.

[Matt Perry, 2009-08-01 00:15:42]

Note that this means VS2005 users will be unable to override this setting.

[bradn, 2009-08-01 00:30:21]

They should be able to by setting GYP_DEFINES to -Dmsvs_multicore_compile=1
-BradN

On Fri, Jul 31, 2009 at 5:15 PM, <mpcomplete@chromium.org> wrote:

> Note that this means VS2005 users will be unable to override this
> setting.
>
>
> http://codereview.chromium.org/159732
>

[Matt Perry, 2009-08-01 00:32:54]

My mistake, I misunderstood how gyp was setting variables up.