Basic infrastructure for fast two-pass compilation. A CFG is...

Basic infrastructure for fast two-pass compilation.  A CFG is
generated in one-pass from the source AST, code is generated from the
CFG.  Enabled by the flag --multipass and disabled by default.

Rudimentary and currently only supports literal expressions and return
statements.  There are some other known limitations (e.g., missing
support for tracing).


Committed: http://code.google.com/p/v8/source/detail?r=2596

[Kasper Lund, 2009-07-31 09:49:25]

Except for the addition of the new files, this LGTM.

http://codereview.chromium.org/159695/diff/1/6
File src/SConscript (right):

http://codereview.chromium.org/159695/diff/1/6#newcode39
Line 39: 'bootstrapper.cc', 'builtins.cc', 'checks.cc', 'cfg.cc',
There are a ton of other places you need to add new files.

http://codereview.chromium.org/159695/diff/1/2
File src/cfg.h (right):

http://codereview.chromium.org/159695/diff/1/2#newcode111
Line 111: virtual void Unmark() = 0;
I think you should add a few comments about the use of the marking/unmarking.

http://codereview.chromium.org/159695/diff/1/2#newcode276
Line 276: ExpressionBuilder() : value_(new Constant(Handle<Object>::null())) {}
Could this null constant be shared?

[Kevin Millikin (Chromium), 2009-07-31 10:07:59]

Changed in the gyp and vcproj files.  You may want to do a sanity check before I
commit.

[antonm, 2009-07-31 13:30:47]

Just an editorial

http://codereview.chromium.org/159695/diff/31/1021
File src/cfg.h (right):

http://codereview.chromium.org/159695/diff/31/1021#newcode209
Line 209: // A CFG is a consists of a linked structure of nodes.  It has a
single
looks like you forgot to remove abandoned phrase.