Fix a hang if directory listing size is > 8K, for example,...

Fix a hang if directory listing size is > 8K, for example,
ftp://ftp.mozilla.org/pub/addons/

The problem is that data was spooling on network stack and
after 8K data TCP Window size becomes small and no more
data is received after 8K.  The fix is to change the
ERROR_CLASS_INITIATED case in the ProcessResponseLIST
function to not go back to the STATE_CTRL_READ state.

In URLRequestNewFtpJob::ProcessFtpDir. construct the
std::string from buf->data() and its length so that
buf->data() doesn't need to be null-terminated.

Author: Ibrar Ahmed <ibrar.ahmad@gmail.com>;

Original review: http://codereview.chromium.org/146137

R=wtc,phajdan.jr
BUG=http://crbug.com/4965
TEST=ftp://ftp.mozilla.org/pub/addons/

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22217

[wtc, 2009-07-30 22:48:49]

Pawel, please review this CL.

Ibrar, please verify that I merged your CL with the current
code correctly, and review my changes (between Patch Sets 1
and 2).

Please verify that the description of the CL matches the
current CL.  I don't understand how the CL fixes the > 8K
directory listing hang...

[Paweł Hajdan Jr., 2009-07-30 22:56:14]

LGTM

It would be nice if you could add a test for this though (you can do that in a
follow-up).

[ibrar, 2009-07-31 07:55:22]

Thanks WTC,

As answer to your question that how it is handling > 8K.

BTW Previously I was not receiving any data from "Data Socket" till I get Data
Completion notification from control socket. 

Now I am start receiving data as its coming it was just a single change in
"ProcessResponseLIST" function

switch (GetErrorClass(response.status_code)) {
 case ERROR_CLASS_INITIATED:
-   next_state_ = STATE_CTRL_READ;
+   response_.is_directory_listing = true;

[wtc, 2009-07-31 17:58:05]

Ibrar, Pawel, please review Patch Set 3.  Note that I added
url_request_new_ftp_job.cc to this CL.

After Ibrar explained in http://codereview.chromium.org/159614
why he needed to null-terminate the data buffer if the data is
directory listing, I figured out a better solution.

Ibrar, please review the new Description of this CL to see if
I described your fix for the hang correctly.  Thanks!

[Paweł Hajdan Jr., 2009-07-31 19:16:50]

LGTM

[ibrar, 2009-08-01 17:30:55]

On 2009/07/31 19:16:50, Paweł Hajdan Jr. wrote:
> LGTM

LGMT

[ibrar, 2009-08-01 17:31:31]

LGTM