Fix a hang if directory listing size is > 8K, for example,...

net/url_request/url_request_new_ftp_job.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request_new_ftp_job.h"
 
 #include "base/compiler_specific.h"
 #include "base/file_version_info.h"
 #include "base/message_loop.h"
 #include "base/sys_string_conversions.h"
@@ skipping 162 matching lines @@
     NotifyDone(URLRequestStatus(URLRequestStatus::FAILED, rv));
   }
   return false;
 }
 
 int URLRequestNewFtpJob::ProcessFtpDir(net::IOBuffer *buf,
                                        int buf_size,
                                        int bytes_read) {
   std::string file_entry;
   std::string line;
-  buf->data()[bytes_read] = 0;
 
   // If all we've seen so far is ASCII, encoding_ is empty. Try to detect the
   // encoding. We don't do the separate UTF-8 check here because the encoding
   // detection with a longer chunk (as opposed to the relatively short path
   // component of the url) is unlikely to mistake UTF-8 for a legacy encoding.
   // If it turns out to be wrong, a separate UTF-8 check has to be added.
   //
   // TODO(jungshik): UTF-8 has to be 'enforced' without any heuristics when
   // we're talking to an FTP server compliant to RFC 2640 (that is, its response
   // to FEAT command includes 'UTF8').
   // See http://wiki.filezilla-project.org/Character_Set
   if (encoding_.empty())
     encoding_ = DetectEncoding(buf->data(), bytes_read);
 
   int64 file_size;
-  std::istringstream iss(buf->data());
+  std::istringstream iss(std::string(buf->data(), bytes_read));
   while (getline(iss, line)) {
     struct net::ListState state;
     struct net::ListResult result;
     std::replace(line.begin(), line.end(), '\r', '\0');
     net::LineType line_type = ParseFTPLine(line.c_str(), &state, &result);
     switch (line_type) {
       case net::FTP_TYPE_DIRECTORY:
         file_entry.append(net::GetDirectoryListingEntry(
             RawByteSequenceToFilename(result.fe_fname, encoding_),
             result.fe_fname, true, 0,
@@ skipping 84 matching lines @@
   MessageLoop::current()->PostTask(FROM_HERE, NewRunnableMethod(
       this, &URLRequestNewFtpJob::OnStartCompleted, rv));
 }
 
 void URLRequestNewFtpJob::DestroyTransaction() {
   DCHECK(transaction_.get());
 
   transaction_.reset();
   response_info_ = NULL;
 }