Add a way to inject extra cflags in release builds....

Add a way to inject extra cflags in release builds.
(I intend to use this as a quickie way to add
-g to Release builds so I can see symbols.
Is there a better way?)


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22064

[dank, 2009-07-30 01:26:44]

So we can get line numbers on linux release valgrind bots.

[Evan Martin, 2009-07-30 01:28:35]

Hm, maybe we should obey CFLAGS from the environment?

[not_the_right_dank, 2009-07-30 03:34:57]

On Wed, Jul 29, 2009 at 6:28 PM, <evan@chromium.org> wrote:
>
> Hm, maybe we should obey CFLAGS from the environment?
>
> http://codereview.chromium.org/159621

I think the trend has been away from generic CFLAGS
environment variables, and towards CFLAGS on the
commandline, where the intent is more explicit?

Anyway, the buildbot scripts have a nice mechanism
for setting gyp variables now, I'd rather use that
than the environment.

[Evan Martin, 2009-07-30 17:35:53]

OK, LGTM

One final thought: maybe just make it plain "extra_flags"?  Since a given build
is only ever building one target, you can then maybe reuse the same variable to
tweak flags on debug or release.

[fta, 2009-07-30 19:05:20]

in Ubuntu, I pass SYMBOLS=1 to scons. If it's in possible in gyp, it's even
better.