Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 159599: Removing tcmalloc from gyp so we can build a version of chrome... (Closed)

Created:
11 years, 4 months ago by huanr
Modified:
9 years ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Removing tcmalloc from gyp so we can build a version of chrome without tcmalloc for testing purpose. The linker complains about _set_new_mode so I remove the call from the code for now. Note this change is different from the change Bradley is working on which provides an option for building chrome without tcmalloc. This change simply removes tcmalloc from the build. The plan is checking it in, keeping it in trunk for 24 hours, and then reverting it. The benefits are - Having another round of performance comparison between build with and w/o tcmalloc. - Having a full run of UI test under purify with tcmalloc disabled. - Getting a verified CL in case we'd like to build an alternative dev build w/o tcmalloc for A/B test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22080

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_dll_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
huanr
11 years, 4 months ago (2009-07-29 18:44:55 UTC) #1
cpu_(ooo_6.6-7.5)
LGTM Do we want to open a bug to track putting back the _set_new_mode() call?
11 years, 4 months ago (2009-07-29 19:49:41 UTC) #2
huanr
The change will be reverted after staying in trunk for 24 hours. But if you ...
11 years, 4 months ago (2009-07-29 19:52:11 UTC) #3
huanr
11 years, 4 months ago (2009-07-29 23:01:13 UTC) #4
bradn
11 years, 4 months ago (2009-07-30 17:41:23 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698