Issue 159583: Change the check for builtin functions to not be based on identity,...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159583: Change the check for builtin functions to not be based on identity,... (Closed)

Created:
11 years, 4 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, yurys

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change the check for builtin functions to not be based on identity, which seems shaky in the presence of multiple builtin objects. Committed: http://code.google.com/p/v8/source/detail?r=2573

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -3 lines)			Patch
M	src/debug.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

On 2009/07/29 09:41:16, Kasper Lund wrote:
> 

LGTM

Expand Messages | Collapse Messages