Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: src/debug.cc

Issue 159583: Change the check for builtin functions to not be based on identity,... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1283 matching lines...) Expand 10 before | Expand all | Expand 10 after
1294 ASSERT(it.frame()->is_construct()); 1294 ASSERT(it.frame()->is_construct());
1295 it.Advance(); 1295 it.Advance();
1296 } 1296 }
1297 fp = it.frame()->fp(); 1297 fp = it.frame()->fp();
1298 } 1298 }
1299 1299
1300 // Flood the function with one-shot break points if it is called from where 1300 // Flood the function with one-shot break points if it is called from where
1301 // step into was requested. 1301 // step into was requested.
1302 if (fp == Debug::step_in_fp()) { 1302 if (fp == Debug::step_in_fp()) {
1303 // Don't allow step into functions in the native context. 1303 // Don't allow step into functions in the native context.
1304 if (function->context()->global() != Top::context()->builtins()) { 1304 if (!function->IsBuiltin()) {
1305 if (function->shared()->code() == 1305 if (function->shared()->code() ==
1306 Builtins::builtin(Builtins::FunctionApply) || 1306 Builtins::builtin(Builtins::FunctionApply) ||
1307 function->shared()->code() == 1307 function->shared()->code() ==
1308 Builtins::builtin(Builtins::FunctionCall)) { 1308 Builtins::builtin(Builtins::FunctionCall)) {
1309 // Handle function.apply and function.call separately to flood the 1309 // Handle function.apply and function.call separately to flood the
1310 // function to be called and not the code for Builtins::FunctionApply or 1310 // function to be called and not the code for Builtins::FunctionApply or
1311 // Builtins::FunctionCall. The receiver of call/apply is the target 1311 // Builtins::FunctionCall. The receiver of call/apply is the target
1312 // function. 1312 // function.
1313 if (!holder.is_null() && holder->IsJSFunction() && 1313 if (!holder.is_null() && holder->IsJSFunction() &&
1314 JSFunction::cast(*holder)->context()->global() != 1314 !JSFunction::cast(*holder)->IsBuiltin()) {
1315 Top::context()->builtins()) {
1316 Handle<SharedFunctionInfo> shared_info( 1315 Handle<SharedFunctionInfo> shared_info(
1317 JSFunction::cast(*holder)->shared()); 1316 JSFunction::cast(*holder)->shared());
1318 Debug::FloodWithOneShot(shared_info); 1317 Debug::FloodWithOneShot(shared_info);
1319 } 1318 }
1320 } else { 1319 } else {
1321 Debug::FloodWithOneShot(Handle<SharedFunctionInfo>(function->shared())); 1320 Debug::FloodWithOneShot(Handle<SharedFunctionInfo>(function->shared()));
1322 } 1321 }
1323 } 1322 }
1324 } 1323 }
1325 } 1324 }
(...skipping 1238 matching lines...) Expand 10 before | Expand all | Expand 10 after
2564 2563
2565 2564
2566 void LockingCommandMessageQueue::Clear() { 2565 void LockingCommandMessageQueue::Clear() {
2567 ScopedLock sl(lock_); 2566 ScopedLock sl(lock_);
2568 queue_.Clear(); 2567 queue_.Clear();
2569 } 2568 }
2570 2569
2571 #endif // ENABLE_DEBUGGER_SUPPORT 2570 #endif // ENABLE_DEBUGGER_SUPPORT
2572 2571
2573 } } // namespace v8::internal 2572 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698