Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 159566: linux: refactor some common flags in common.gypi (Closed)

Created:
11 years, 4 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Lei Zhang, agl, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: refactor some common flags in common.gypi No functional change, just reducing some cruft.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M build/common.gypi View 3 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
Mostly I noticed that the arm branch of the if was a subset of the ...
11 years, 4 months ago (2009-07-29 00:43:50 UTC) #1
agl
LGTM
11 years, 4 months ago (2009-07-29 00:49:14 UTC) #2
Lei Zhang
LGTM (I did the ARM stuff, and someone from ChromeOS worked with sgk to get ...
11 years, 4 months ago (2009-07-29 00:51:10 UTC) #3
sgk
11 years, 4 months ago (2009-07-29 16:04:04 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698