linux: refactor some common flags in common.gypi

build/common.gypi

 # Copyright (c) 2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     # .gyp files should set chromium_code to 1 if they build Chromium-specific
     # code, as opposed to external code.  This variable is used to control
     # such things as the set of warnings to enable, and whether warnings are
     # treated as errors.
@@ skipping 224 matching lines @@
     ['OS=="linux"', {
       'target_defaults': {
         # Enable -Werror by default, but put it in a variable so it can
         # be disabled in ~/.gyp/include.gypi on the valgrind builders.
         'variables': {
           'werror%': '-Werror',
         },
         'cflags': [
            '<(werror)',  # See note above about the werror variable.
            '-pthread',
+           '-fno-exceptions',
+           '-Wall',
+        ],
+        'cflags_cc': [
+          '-fno-threadsafe-statics',
         ],
         'ldflags': [
           '-pthread',
         ],
         'scons_variable_settings': {
           'LIBPATH': ['$LIB_DIR'],
           # Linking of large files uses lots of RAM, so serialize links
           # using the handy flock command from util-linux.
           'FLOCK_LINK': ['flock', '$TOP_BUILDDIR/linker.lock', '$LINK'],
           'FLOCK_SHLINK': ['flock', '$TOP_BUILDDIR/linker.lock', '$SHLINK'],
@@ skipping 93 matching lines @@
           },
           'profile': {
             'cflags': ['-pg', '-g'],
             'ldflags': ['-pg'],
           },
           'symbols': {
             'cflags': ['-g'],
           },
         },
         'conditions': [
-          [ 'target_arch=="arm"', {
-            'cflags': [
-              '-fno-exceptions',
-              '-Wall',
-            ],
-            'cflags_cc': [
-              '-fno-threadsafe-statics',
-            ],
-          }, { # else: target_arch != "arm"
+          [ 'target_arch!="arm"', {
             'asflags': [
               # Needed so that libs with .s files (e.g. libicudata.a)
               # are compatible with the general 32-bit-ness.
               '-32',
             ],
             # All floating-point computations on x87 happens in 80-bit
             # precision.  Because the C and C++ language standards allow
             # the compiler to keep the floating-point values in higher
             # precision than what's specified in the source and doing so
             # is more efficient than constantly rounding up to 64-bit or
@@ skipping 21 matching lines @@
               ['branding=="Chromium"', {
                 'cflags': [
                   '-march=pentium4',
                   '-msse2',
                   '-mfpmath=sse',
                 ],
               }],
             ],
             'cflags': [
               '-m32',
-              '-fno-exceptions',
-              '-Wall',
-            ],
-            'cflags_cc': [
-              '-fno-threadsafe-statics',
             ],
             'ldflags': [
               '-m32',
             ],
           }],
         ],
       },
     }],
     ['OS=="mac"', {
       'target_defaults': {
@@ skipping 194 matching lines @@
     # settings in target dicts.  SYMROOT is a special case, because many other
     # Xcode variables depend on it, including variables such as
     # PROJECT_DERIVED_FILE_DIR.  When a source group corresponding to something
     # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
     # files to appear (when present) in the UI as actual files and not red
     # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }