Issue 159402: Make X64 implementation update Store ic stubs. Remove comment that talks abo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159402: Make X64 implementation update Store ic stubs. Remove comment that talks abo... (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Make X64 implementation update Store ic stubs. Remove comment that talks about "below" on the stack meaning closer to the top. Committed: http://code.google.com/p/v8/source/detail?r=2539

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -47 lines)			Patch
M	src/ia32/ic-ia32.cc	View	3 chunks	+11 lines, -15 lines	1 comment	Download
M	src/ic.cc	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	4 chunks	+32 lines, -21 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

11 years, 5 months ago (2009-07-27 10:32:11 UTC) #2

LGTM.

http://codereview.chromium.org/159402/diff/1/2
File src/ia32/ic-ia32.cc (right):

http://codereview.chromium.org/159402/diff/1/2#newcode752
Line 752: __ pop(ebx);
Perhaps add comment to this line as well?
// return address

Expand Messages | Collapse Messages