Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 159402: Make X64 implementation update Store ic stubs. Remove comment that talks abo... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 144
145 Runtime::FunctionId function_id = 145 Runtime::FunctionId function_id =
146 static_cast<Runtime::FunctionId>(f->stub_id); 146 static_cast<Runtime::FunctionId>(f->stub_id);
147 RuntimeStub stub(function_id, num_arguments); 147 RuntimeStub stub(function_id, num_arguments);
148 CallStub(&stub); 148 CallStub(&stub);
149 } 149 }
150 150
151 151
152 void MacroAssembler::TailCallRuntime(ExternalReference const& ext, 152 void MacroAssembler::TailCallRuntime(ExternalReference const& ext,
153 int num_arguments) { 153 int num_arguments) {
154 // ----------- S t a t e -------------
155 // -- rsp[0] : return address
156 // -- rsp[8] : argument num_arguments - 1
157 // ...
158 // -- rsp[8 * num_arguments] : argument 0 (receiver)
159 // -----------------------------------
160
154 // TODO(1236192): Most runtime routines don't need the number of 161 // TODO(1236192): Most runtime routines don't need the number of
155 // arguments passed in because it is constant. At some point we 162 // arguments passed in because it is constant. At some point we
156 // should remove this need and make the runtime routine entry code 163 // should remove this need and make the runtime routine entry code
157 // smarter. 164 // smarter.
158 movq(rax, Immediate(num_arguments)); 165 movq(rax, Immediate(num_arguments));
159 JumpToBuiltin(ext); 166 JumpToBuiltin(ext);
160 } 167 }
161 168
162 169
163 void MacroAssembler::JumpToBuiltin(const ExternalReference& ext) { 170 void MacroAssembler::JumpToBuiltin(const ExternalReference& ext) {
(...skipping 862 matching lines...) Expand 10 before | Expand all | Expand 10 after
1026 Context::SECURITY_TOKEN_INDEX * kPointerSize; 1033 Context::SECURITY_TOKEN_INDEX * kPointerSize;
1027 movq(scratch, FieldOperand(scratch, token_offset)); 1034 movq(scratch, FieldOperand(scratch, token_offset));
1028 cmpq(scratch, FieldOperand(kScratchRegister, token_offset)); 1035 cmpq(scratch, FieldOperand(kScratchRegister, token_offset));
1029 j(not_equal, miss); 1036 j(not_equal, miss);
1030 1037
1031 bind(&same_contexts); 1038 bind(&same_contexts);
1032 } 1039 }
1033 1040
1034 1041
1035 } } // namespace v8::internal 1042 } } // namespace v8::internal
OLDNEW
« src/ia32/ic-ia32.cc ('K') | « src/x64/ic-x64.cc ('k') | src/x64/stub-cache-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698