Issue 159395: DevTools: make pause work for script evaluations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159395: DevTools: make pause work for script evaluations (Closed)

Created:
11 years, 5 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com, darin (slow to review), Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

DevTools: split console evaluation into two steps: actual evaluation and result wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21635 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21637

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -30 lines)			Patch
M	chrome/browser/debugger/devtools_sanity_unittest.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_impl.h	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_impl.cc	View	1 2	2 chunks	+59 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_manager.h	View	1 2	2 chunks	+20 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/debugger_agent_manager.cc	View	1 2	3 chunks	+29 lines, -9 lines	0 comments	Download
M	webkit/glue/devtools/js/devtools.js	View	1 2	1 chunk	+12 lines, -9 lines	0 comments	Download
M	webkit/glue/devtools/js/inject.js	View	1 2	2 chunks	+12 lines, -11 lines	0 comments	Download
M	webkit/glue/devtools/js/tests.js	View	1 2	1 chunk	+22 lines, -0 lines	0 comments	Download
M	webkit/glue/devtools/tools_agent.h	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webdevtoolsagent_impl.cc	View	1 2	1 chunk	+9 lines, -0 lines	0 comments	Download
M	webkit/glue/webkit_resources.grd	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

yurys

This is second attempt to land change http://codereview.chromium.org/160012 without breaking interactive UI tests.

11 years, 5 months ago (2009-07-27 07:08:11 UTC) #1

yurys

11 years, 5 months ago (2009-07-27 09:15:39 UTC) #4

On 2009/07/27 07:54:10, pfeldman wrote:
> LGTM

Added emtpy change to webkit_resources.grd to force resources rebuild.