DevTools: make pause work for script evaluations

DevTools: split console evaluation into two steps: actual evaluation and result wrapping. When second step is executed debugger_agent_manager will autocontinue on break. We assume that second step doesn't call user scripts.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21525

[pfeldman, 2009-07-23 15:47:04]

http://codereview.chromium.org/160012/diff/1/5
File webkit/glue/devtools/debugger_agent_impl.h (right):

http://codereview.chromium.org/160012/diff/1/5#newcode60
Line 60: WebCore::String Evaluate(
So who calls this one?

http://codereview.chromium.org/160012/diff/1/2
File webkit/glue/devtools/debugger_agent_manager.cc (right):

http://codereview.chromium.org/160012/diff/1/2#newcode55
Line 55: v8::Local<v8::Function> GetMethod(v8::Handle<v8::Object> obj, const
char* name) {
80 chars

http://codereview.chromium.org/160012/diff/1/2#newcode224
Line 224: if (message.GetEvent() == v8::Break) {
Can this actually happen? Who issues continue here?

http://codereview.chromium.org/160012/diff/1/7
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/160012/diff/1/7#newcode80
Line 80: RemoteToolsAgent.ExecuteUtilityFunction(callbackId,
This is most likely a bug. Are you calling ExecuteUtilityFunction? If yes - it
requires json!

http://codereview.chromium.org/160012/diff/1/6
File webkit/glue/devtools/js/inject.js (right):

http://codereview.chromium.org/160012/diff/1/6#newcode556
Line 556: return [result, false];
this will break console, etc.

[yurys, 2009-07-24 07:21:04]

http://codereview.chromium.org/160012/diff/1/5
File webkit/glue/devtools/debugger_agent_impl.h (right):

http://codereview.chromium.org/160012/diff/1/5#newcode60
Line 60: WebCore::String Evaluate(
On 2009/07/23 15:47:04, pfeldman wrote:
> So who calls this one?
Added webdevtoolsagent_impl.cc to the CL.

http://codereview.chromium.org/160012/diff/1/2
File webkit/glue/devtools/debugger_agent_manager.cc (right):

http://codereview.chromium.org/160012/diff/1/2#newcode55
Line 55: v8::Local<v8::Function> GetMethod(v8::Handle<v8::Object> obj, const
char* name) {
On 2009/07/23 15:47:04, pfeldman wrote:
> 80 chars

Done.

http://codereview.chromium.org/160012/diff/1/2#newcode224
Line 224: if (message.GetEvent() == v8::Break) {
On 2009/07/23 15:47:04, pfeldman wrote:
> Can this actually happen?
It can e.g. when debug break is forced from a nested message loop.

> Who issues continue here?
SendContinueCommandToV8 is called a few lines below.

http://codereview.chromium.org/160012/diff/1/7
File webkit/glue/devtools/js/devtools.js (right):

http://codereview.chromium.org/160012/diff/1/7#newcode80
Line 80: RemoteToolsAgent.ExecuteUtilityFunction(callbackId,
On 2009/07/23 15:47:04, pfeldman wrote:
> This is most likely a bug. Are you calling ExecuteUtilityFunction? If yes - it
> requires json!
Look at webdevtoolsagent_impl.cc. This param is passed as is to
DebuggerAgentImpl::Evaluate.

[pfeldman, 2009-07-24 10:43:59]

LGTM with comments. I know you will change it before submitting anyway :)

http://codereview.chromium.org/160012/diff/1002/24
File webkit/glue/devtools/debugger_agent_manager.cc (right):

http://codereview.chromium.org/160012/diff/1002/24#newcode214
Line 214: if (in_utility_context_) {
could you please explain the two-tab scenario in the comments here? this is
really non-trivial.

http://codereview.chromium.org/160012/diff/35/1008
File webkit/glue/devtools/debugger_agent_impl.cc (right):

http://codereview.chromium.org/160012/diff/35/1008#newcode222
Line 222: } else if (res_obj.IsEmpty()) {
Do you want to investigate why you are getting empty handle here?

http://codereview.chromium.org/160012/diff/35/1008#newcode240
Line 240: v8::TryCatch try_catch;
this will not fail.

http://codereview.chromium.org/160012/diff/35/1010
File webkit/glue/devtools/js/inject.js (right):

http://codereview.chromium.org/160012/diff/35/1010#newcode551
Line 551: var type = typeof obj;
what is wrong with indent here?

[yurys, 2009-07-24 12:35:56]

http://codereview.chromium.org/160012/diff/1002/24
File webkit/glue/devtools/debugger_agent_manager.cc (right):

http://codereview.chromium.org/160012/diff/1002/24#newcode214
Line 214: if (in_utility_context_) {
On 2009/07/24 10:43:59, pfeldman wrote:
> could you please explain the two-tab scenario in the comments here? this is
> really non-trivial.

Done.

http://codereview.chromium.org/160012/diff/35/1008
File webkit/glue/devtools/debugger_agent_impl.cc (right):

http://codereview.chromium.org/160012/diff/35/1008#newcode240
Line 240: v8::TryCatch try_catch;
On 2009/07/24 10:43:59, pfeldman wrote:
> this will not fail.

Done.

http://codereview.chromium.org/160012/diff/35/1010
File webkit/glue/devtools/js/inject.js (right):

http://codereview.chromium.org/160012/diff/35/1010#newcode551
Line 551: var type = typeof obj;
On 2009/07/24 10:43:59, pfeldman wrote:
> what is wrong with indent here?

Done.

[pfeldman, 2009-07-27 07:50:14]

LGTM with comments

http://codereview.chromium.org/160012/diff/1066/96
File webkit/glue/devtools/debugger_agent_impl.cc (right):

http://codereview.chromium.org/160012/diff/1066/96#newcode200
Line 200: v8::Handle<v8::Context> v8Context =
V8Proxy::context(GetPage()->mainFrame());
80 chars

http://codereview.chromium.org/160012/diff/1066/100
File webkit/glue/devtools/js/tests.js (right):

http://codereview.chromium.org/160012/diff/1066/100#newcode461
Line 461: alert(0);
alert?

[yurys, 2009-07-27 07:52:05]

http://codereview.chromium.org/160012/diff/1066/96
File webkit/glue/devtools/debugger_agent_impl.cc (right):

http://codereview.chromium.org/160012/diff/1066/96#newcode200
Line 200: v8::Handle<v8::Context> v8Context =
V8Proxy::context(GetPage()->mainFrame());
On 2009/07/27 07:50:15, pfeldman wrote:
> 80 chars

Done.