Adding two new windows configuration types:...

Adding two new windows configuration types:
Purify
Release - no tcmalloc

This is done more pedantically than I'd like,
so I've left in some TODOs. Eventually either gyp needs to support some
notion of inheritance in configurations, or maybe we can make clever use
of includes.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22433

[huanr, 2009-07-24 20:55:51]

Feel free to ignore my comments as I don't know much of gyp.

Do you need to remove the dependency on tcmalloc from chrome.dll in chrome.gyp
or all.gyp, or it is done by your change in common.gypi?

[bradn, 2009-07-24 21:01:39]

So yeah ideally I'd like that, but
dependencies aren't (at least as far as I can tell) able to be
different based on the configuration. So my next best thing solution
is to still have tcmalloc.lib in the link line, but not the altered
libcmt.lib.
The tcmalloc part should just get distilled out. Or am I missing something?
-BradN

On Fri, Jul 24, 2009 at 1:55 PM, <huanr@chromium.org> wrote:

> Feel free to ignore my comments as I don't know much of gyp.
>
> Do you need to remove the dependency on tcmalloc from chrome.dll in
> chrome.gyp or all.gyp, or it is done by your change in common.gypi?
>
>
> http://codereview.chromium.org/159362
>

[huanr, 2009-07-24 21:07:16]

LGTM

Huan

[Added Mike]


On Fri, Jul 24, 2009 at 2:01 PM, Bradley Nelson<bradnelson@google.com> wrot=
e:
> So yeah ideally I'd like that, but
> dependencies=A0aren't=A0(at=A0least=A0as=A0far=A0as=A0I=A0can=A0tell)=A0a=
ble=A0to=A0be=A0different=A0based=A0on=A0the=A0configuration.=A0So=A0my=A0n=
ext=A0best=A0thing=A0solution=A0is=A0to=A0still=A0have=A0tcmalloc.lib=A0in=
=A0the=A0link=A0line,=A0but=A0not=A0the=A0altered=A0libcmt.lib.
> The tcmalloc part should just get distilled out.=A0Or=A0am=A0I=A0missing=
=A0something?
> -BradN
>
> On Fri, Jul 24, 2009 at 1:55 PM, <huanr@chromium.org> wrote:
>>
>> Feel free to ignore my comments as I don't know much of gyp.
>>
>> Do you need to remove the dependency on tcmalloc from chrome.dll in
>> chrome.gyp or all.gyp, or it is done by your change in common.gypi?
>>
>> http://codereview.chromium.org/159362
>
>

[Erik does not do reviews, 2009-07-25 00:54:51]

I don't understand gyp enough to see how this prevents tcmalloc from linking in
the Purify and no_tcmalloc case. Seems like we need another reviewer. Does this
change also change the default settings so that other projects now link against
tcmalloc by default?

http://codereview.chromium.org/159362/diff/1/3
File build/common.gypi (right):

http://codereview.chromium.org/159362/diff/1/3#newcode259
Line 259: 'defines': [
Let's add a define here that says NO_TCMALLOC.  There's one line of code that we
call when we link with tcmalloc that should be #ifdef'd out if we don't.

[huanr, 2009-07-27 17:55:21]

Mike can you review this change?

[Mike Belshe, 2009-08-03 17:06:56]

lgtm.

I can't say I'm an expert on gyp, but it looks like there is just a new release
target which avoids the tcmalloc dependency and linker changes.

http://codereview.chromium.org/159362/diff/1/2
File third_party/tcmalloc/tcmalloc.gyp (right):

http://codereview.chromium.org/159362/diff/1/2#newcode25
Line 25: # TODO(bradnelson): find a way to make this more graceful in gyp.
What is ungraceful? That we have duplicated lines for 'debug' and 'release'?