Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 159305: First pass at NNTP theming.... (Closed)

Created:
11 years, 5 months ago by Glen Murphy
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

Fix a bunch of bugs related to NNTP theming. Basically: - Add NNTP Theming BrowserThemeProvider: - Add NNTP logo inversion capability - Only allow a set of images to be themed. - Tint incognito windows correctly. (Sorry for the feature-mush) BUG=17379, 14578, 17593 TEST=Make sure the NNTP is themed correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21509

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 8

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -34 lines) Patch
M chrome/app/theme/chromium/product_logo.png View Binary file 0 comments Download
A chrome/app/theme/chromium/product_logo_white.png View Binary file 0 comments Download
M chrome/app/theme/ntp_close.png View Binary file 0 comments Download
M chrome/app/theme/ntp_close_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_close_p.png View Binary file 0 comments Download
M chrome/app/theme/ntp_list_off.png View Binary file 0 comments Download
M chrome/app/theme/ntp_list_off_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_list_off_p.png View Binary file 0 comments Download
M chrome/app/theme/ntp_list_on.png View Binary file 0 comments Download
M chrome/app/theme/ntp_list_on_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_list_on_p.png View Binary file 0 comments Download
A chrome/app/theme/ntp_menu_mask.png View Binary file 0 comments Download
M chrome/app/theme/ntp_option.png View Binary file 0 comments Download
M chrome/app/theme/ntp_option_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_option_p.png View Binary file 0 comments Download
M chrome/app/theme/ntp_pin_off.png View Binary file 0 comments Download
M chrome/app/theme/ntp_pin_off_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_pin_off_p.png View Binary file 0 comments Download
M chrome/app/theme/ntp_pin_on.png View Binary file 0 comments Download
M chrome/app/theme/ntp_pin_on_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_pin_on_p.png View Binary file 0 comments Download
M chrome/app/theme/ntp_thumb_off.png View Binary file 0 comments Download
M chrome/app/theme/ntp_thumb_off_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_thumb_off_p.png View Binary file 0 comments Download
M chrome/app/theme/ntp_thumb_on.png View Binary file 0 comments Download
M chrome/app/theme/ntp_thumb_on_h.png View Binary file 0 comments Download
M chrome/app/theme/ntp_thumb_on_p.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/browser_theme_provider.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/browser_theme_provider.cc View 2 18 chunks +105 lines, -14 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_theme_source.cc View 1 2 3 3 chunks +27 lines, -10 lines 0 comments Download
M chrome/browser/resources/new_new_tab.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/new_tab_theme.css View 1 2 1 chunk +47 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Glen Murphy
11 years, 5 months ago (2009-07-24 00:00:41 UTC) #1
arv (Not doing code reviews)
http://codereview.chromium.org/159305/diff/78/1042 File chrome/browser/browser_theme_provider.cc (right): http://codereview.chromium.org/159305/diff/78/1042#newcode599 Line 599: if (display_properties_value->GetString(*iter, &val)) Do you intend to submit ...
11 years, 5 months ago (2009-07-24 00:25:12 UTC) #2
Glen Murphy
http://codereview.chromium.org/159305/diff/78/1042 File chrome/browser/browser_theme_provider.cc (right): http://codereview.chromium.org/159305/diff/78/1042#newcode599 Line 599: if (display_properties_value->GetString(*iter, &val)) On 2009/07/24 00:25:14, arv wrote: ...
11 years, 5 months ago (2009-07-24 02:16:24 UTC) #3
arv (Not doing code reviews)
11 years, 5 months ago (2009-07-24 02:20:33 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698