Issue 1593003: Added mute key handling to the WM. Also removed ACPI hotkey handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1593003: Added mute key handling to the WM. Also removed ACPI hotkey handler (Closed)

Created:
10 years, 8 months ago by Sameer Nanda

Modified:
9 years, 5 months ago

Reviewers:
Daniel Erat, awong, sosa

CC:
chromium-os-reviews_chromium.org, Greg Spencer (Chromium), Daniel Erat

Visibility:
Public.

Description

Added mute key handling to the WM. Also removed ACPI hotkey handler since all the hotkeys it was handling (volume up, down, mute) are now handled by the WM. TESTED: eeepc 1008ha, x200 BUG: 2192

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -37 lines)			Patch
D	src/platform/acpi/action_hotkey.sh	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	src/platform/acpi/event_hotkey	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/platform/window_manager/window_manager.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM On Wed, Mar 31, 2010 at 11:15 AM, <derat@chromium.org> wrote: > LGTM! > > ...

10 years, 8 months ago (2010-03-31 18:49:43 UTC) #4

bradn

10 years, 4 months ago (2010-08-19 17:11:10 UTC) #5

Nacl still uses scons for some things, but not the gyp scons generator.
And they don't use runtest.py

-BradN

On Thu, Aug 19, 2010 at 6:57 AM, <maruel@google.com> wrote:

> Brad, doesn't NaCl still use Scons? Do they use runtest.py at all? I guess
> not
> but I just want to confirm first.
>
> https://chromereview.prom.corp.google.com/1593003/show
>

Expand Messages | Collapse Messages