Issue 159266: Add inline caching for keyed loads and stores. Remove extra parentheses from...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159266: Add inline caching for keyed loads and stores. Remove extra parentheses from... (Closed)

Created:
11 years, 5 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Add inline caching for keyed loads and stores. Remove extra parentheses from some files. Committed: http://code.google.com/p/v8/source/detail?r=2534

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+406 lines, -41 lines)			Patch
M	src/ia32/ic-ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1	13 chunks	+20 lines, -20 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1	3 chunks	+11 lines, -2 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/disasm-x64.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/ic-x64.cc	View	1	4 chunks	+327 lines, -9 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	4 chunks	+33 lines, -3 lines	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

William Hesse

This fails a couple of tests. I am working on fixing it.

11 years, 5 months ago (2009-07-23 12:59:51 UTC) #1

William Hesse

This now passes all tests. There are three things in this changelist: 1) Add generic ...

11 years, 5 months ago (2009-07-24 08:25:42 UTC) #2

LGTM