Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/ia32/ic-ia32.cc

Issue 159266: Add inline caching for keyed loads and stores. Remove extra parentheses from... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 230
231 void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) { 231 void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) {
232 // ----------- S t a t e ------------- 232 // ----------- S t a t e -------------
233 // -- esp[0] : return address 233 // -- esp[0] : return address
234 // -- esp[4] : name 234 // -- esp[4] : name
235 // -- esp[8] : receiver 235 // -- esp[8] : receiver
236 // ----------------------------------- 236 // -----------------------------------
237 Label slow, fast, check_string, index_int, index_string; 237 Label slow, fast, check_string, index_int, index_string;
238 238
239 // Load name and receiver. 239 // Load name and receiver.
240 __ mov(eax, (Operand(esp, kPointerSize))); 240 __ mov(eax, Operand(esp, kPointerSize));
241 __ mov(ecx, (Operand(esp, 2 * kPointerSize))); 241 __ mov(ecx, Operand(esp, 2 * kPointerSize));
242 242
243 // Check that the object isn't a smi. 243 // Check that the object isn't a smi.
244 __ test(ecx, Immediate(kSmiTagMask)); 244 __ test(ecx, Immediate(kSmiTagMask));
245 __ j(zero, &slow, not_taken); 245 __ j(zero, &slow, not_taken);
246 246
247 // Get the map of the receiver. 247 // Get the map of the receiver.
248 __ mov(edx, FieldOperand(ecx, HeapObject::kMapOffset)); 248 __ mov(edx, FieldOperand(ecx, HeapObject::kMapOffset));
249 // Check that the receiver does not require access checks. We need 249 // Check that the receiver does not require access checks. We need
250 // to check this explicitly since this generic stub does not perform 250 // to check this explicitly since this generic stub does not perform
251 // map checks. 251 // map checks.
(...skipping 738 matching lines...) Expand 10 before | Expand all | Expand 10 after
990 990
991 // Do tail-call to runtime routine. 991 // Do tail-call to runtime routine.
992 __ TailCallRuntime( 992 __ TailCallRuntime(
993 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3); 993 ExternalReference(IC_Utility(kSharedStoreIC_ExtendStorage)), 3);
994 } 994 }
995 995
996 #undef __ 996 #undef __
997 997
998 998
999 } } // namespace v8::internal 999 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698