Issue 159264: Change a few style issues (dead code, unitialized members) flagged by...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159264: Change a few style issues (dead code, unitialized members) flagged by... (Closed)

Created:
11 years, 5 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
iposva, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change a few style issues (dead code, unitialized members) flagged by Coverity Prevent. All are benign. Committed: http://code.google.com/p/v8/source/detail?r=2525

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -10 lines)			Patch
M	src/bootstrapper.cc	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	src/rewriter.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/spaces.cc	View	1 chunk	+0 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iposva

11 years, 5 months ago (2009-07-23 18:14:57 UTC) #3

http://codereview.chromium.org/159264/diff/1/3
File src/spaces.cc (left):

http://codereview.chromium.org/159264/diff/1/3#oldcode136
Line 136: default:
What was the complaint by Coverity here? It is really helpful to have default
cases marked as UNREACHABLE once you start adding new entries to the Mode enum.

Expand Messages | Collapse Messages