Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 159264: Change a few style issues (dead code, unitialized members) flagged by... (Closed)

Created:
11 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Change a few style issues (dead code, unitialized members) flagged by Coverity Prevent. All are benign. Committed: http://code.google.com/p/v8/source/detail?r=2525

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/rewriter.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/spaces.cc View 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 5 months ago (2009-07-23 12:04:21 UTC) #1
Mads Ager (chromium)
LGTM
11 years, 5 months ago (2009-07-23 12:49:20 UTC) #2
iposva
11 years, 5 months ago (2009-07-23 18:14:57 UTC) #3
http://codereview.chromium.org/159264/diff/1/3
File src/spaces.cc (left):

http://codereview.chromium.org/159264/diff/1/3#oldcode136
Line 136: default:
What was the complaint by Coverity here? It is really helpful to have default
cases marked as UNREACHABLE once you start adding new entries to the Mode enum.

Powered by Google App Engine
This is Rietveld 408576698