Change a few style issues (dead code, unitialized members) flagged by...

src/spaces.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 115 matching lines @@
       // Verify that the cached last page in the space is actually the
       // last page.
       for (Page* p = space->first_page_; p->is_valid(); p = p->next_page()) {
         if (!p->next_page()->is_valid()) {
           ASSERT(space->last_page_ == p);
         }
       }
 #endif
       stop_page_ = space->last_page_;
       break;
-    default:

[iposva, 2009/07/23 18:14:57]

What was the complaint by Coverity here? It is really helpful to have default
cases marked as UNREACHABLE once you start adding new entries to the Mode enum.

-      UNREACHABLE();
   }
 }
 
 
 // -----------------------------------------------------------------------------
 // Page
 
 #ifdef DEBUG
 Page::RSetState Page::rset_state_ = Page::IN_USE;
 #endif
@@ skipping 2447 matching lines @@
                      reinterpret_cast<Object**>(object->address()
                                                 + Page::kObjectAreaSize),
                      allocation_top);
       PrintF("\n");
     }
   }
 }
 #endif  // DEBUG
 
 } }  // namespace v8::internal