Issue 159219: Add a localizer for the bookmark bar and editor....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159219: Add a localizer for the bookmark bar and editor.... (Closed)

Created:
11 years, 5 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Put the common paths for localizers into variables so we don't have to repeat as much. Merge in the missing app_strings resources. Include app_strings.h in the generated localizers for the shared button titles in dialogs. TEST=none BUG=16764 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21951

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	build/mac/generate_localizer	View	2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/chrome.gyp	View	1 2	6 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

TVL

Splitting this off so I can land it independent of other stuff I'm doing. Tony ...

11 years, 4 months ago (2009-07-29 14:22:14 UTC) #1

tony

11 years, 4 months ago (2009-07-29 16:56:09 UTC) #3

On 2009/07/29 14:22:14, TVL wrote:
> Tony - The app strings should be where button titles for "ok", "cancel", etc.
> come from for the UI, since we weren't including this, I'm not sure where
linux
> was getting the values for these.

It looks like linux wasn't using any of the strings in app_strings.grd.  We get
default button titles like OK/Cancel from GTK+.  This change LGTM

Expand Messages | Collapse Messages