Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 159159: Rebaseline some layout-tests which changed in upstrea webkit r46412.... (Closed)

Created:
11 years, 5 months ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
rniwa
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Rebaseline some layout-tests which changed in upstream webkit r46412. BUG=http://crbug.com/17326 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21245

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -48 lines) Patch
MM webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/indent-selection-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-linux/LayoutTests/editing/execCommand/indent-selection-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/4641880-2-expected.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/4916541-expected.txt View 1 chunk +8 lines, -6 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/5138441-expected.txt View 1 chunk +6 lines, -4 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/5481523-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
MM webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/indent-selection-expected.checksum View 1 chunk +1 line, -1 line 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/indent-selection-expected.png View Binary file 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/execCommand/indent-selection-expected.txt View 2 chunks +24 lines, -23 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
11 years, 5 months ago (2009-07-21 21:43:11 UTC) #1
rniwa
Thank you for rebaselining it. I think we figured out other regression about 19087.html & ...
11 years, 5 months ago (2009-07-21 21:46:42 UTC) #2
eroman
So should I hold off on the rebaseline until this happens?
11 years, 5 months ago (2009-07-21 21:48:41 UTC) #3
rniwa
On Tue, Jul 21, 2009 at 2:48 PM, <eroman@chromium.org> wrote: > So should I hold ...
11 years, 5 months ago (2009-07-21 22:04:02 UTC) #4
rniwa
11 years, 5 months ago (2009-07-21 23:11:20 UTC) #5
Hi Eric:
I just landed my patch for the regression.  I should make the tree happy
soon.

Ryosuke

On Tue, Jul 21, 2009 at 3:03 PM, Ryosuke Niwa <rniwa@google.com> wrote:

> On Tue, Jul 21, 2009 at 2:48 PM, <eroman@chromium.org> wrote:
>
>> So should I hold off on the rebaseline until this happens?
>>
>>
>> http://codereview.chromium.org/159159
>>
>
> You can still rebaseline tests.  My new patch only fixes REGRESSION
> (r46142): editing/execCommand/19087.html & editing/execCommand/19653-1.html.
> It doesn't change any other test results I rebaselined. Thanks for follow up
> though.
> Best regards,
> Ryosuke
>
>

Powered by Google App Engine
This is Rietveld 408576698