Issue 159135: DevTools Profiler: small UI improvements....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159135: DevTools Profiler: small UI improvements.... (Closed)

Created:
11 years, 5 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
pfeldman

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

DevTools Profiler: small UI improvements. - if profile is generated, and no profile is shown, show the new one; - display processed ticks count during processing to show that we're alive. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21176

Patch Set 1 #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -2 lines)			Patch
	M	webkit/glue/devtools/js/debugger_agent.js	View		1 chunk	+12 lines, -1 line	0 comments	Download
	M	webkit/glue/devtools/js/profiler_processor.js	View		6 chunks	+24 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pfeldman

LGTM http://codereview.chromium.org/159135/diff/1/2 File webkit/glue/devtools/js/profiler_processor.js (right): http://codereview.chromium.org/159135/diff/1/2#newcode304 Line 304: window.clearInterval(processingInterval); should this be checked for nullness?

11 years, 5 months ago (2009-07-21 14:58:47 UTC) #2

mnaganov (inactive)

11 years, 5 months ago (2009-07-21 15:06:29 UTC) #3

http://codereview.chromium.org/159135/diff/1/2
File webkit/glue/devtools/js/profiler_processor.js (right):

http://codereview.chromium.org/159135/diff/1/2#newcode304
Line 304: window.clearInterval(processingInterval);
On 2009/07/21 14:58:49, pfeldman wrote:
> should this be checked for nullness?

window.clearInterval(null) is harmless.

Expand Messages | Collapse Messages