Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: webkit/glue/devtools/js/debugger_agent.js

Issue 159135: DevTools Profiler: small UI improvements.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/devtools/js/debugger_agent.js
===================================================================
--- webkit/glue/devtools/js/debugger_agent.js (revision 21170)
+++ webkit/glue/devtools/js/debugger_agent.js (working copy)
@@ -500,16 +500,27 @@
devtools.DebuggerAgent.prototype.setupProfilerProcessorCallbacks = function() {
// A temporary icon indicating that the profile is being processed.
var processingIcon = new WebInspector.SidebarTreeElement(
- "profile-sidebar-tree-item", "Processing...", "", null, false);
+ 'profile-sidebar-tree-item', 'Processing...', '', null, false);
var profilesSidebar = WebInspector.panels.profiles.sidebarTree;
this.profilerProcessor_.setCallbacks(
function onProfileProcessingStarted() {
+ // Set visually empty string. Subtitle hiding is done via styles
+ // manipulation which doesn't play well with dynamic append / removal.
+ processingIcon.subtitle = ' ';
profilesSidebar.appendChild(processingIcon);
},
+ function onProfileProcessingStatus(ticksCount) {
+ processingIcon.subtitle = ticksCount + ' ticks processed';
+ },
function onProfileProcessingFinished(profile) {
profilesSidebar.removeChild(processingIcon);
WebInspector.addProfile(profile);
+ // If no profile is currently shown, show the new one.
+ var profilesPanel = WebInspector.panels.profiles;
+ if (!profilesPanel.visibleView) {
+ profilesPanel.showProfile(profile);
+ }
}
);
};
« no previous file with comments | « no previous file | webkit/glue/devtools/js/profiler_processor.js » ('j') | webkit/glue/devtools/js/profiler_processor.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698