Refactor tar code to support long names....

Refactor tar code to support long names.

The previous code only support names up to 99 chars.
This one supports up to 1024. The code actually 
supports 32bit length but given that Linux, OSX and
other only support 255 I set it 1024. Why 1024?
Because Windows actually supports 255 wchar characters
which when converted to utf-8 could be up to 1024 bytes.

I'm not 100% sure the format is correct. I could not
find any docs on the format, Just reverse engineered it.

Looking at hex dumps by both 7zip and gnu tar it was
pretty clear what it does including zeroing many
of the standard fields.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21210

[Chris Rogers, 2009-07-21 19:14:28]

LGTM - I'd add a few comments where I've noted...

http://codereview.chromium.org/159129/diff/1/6
File import/cross/tar_generator.cc (right):

http://codereview.chromium.org/159129/diff/1/6#newcode57
Line 57: static const char* kLongLink = "././@LongLink";
comment explaining what kLongLink is

http://codereview.chromium.org/159129/diff/1/6#newcode131
Line 131: // for our use case
maybe should adjust comment to say this can indicate a directory, ordinary file,
or long filename

http://codereview.chromium.org/159129/diff/1/3
File import/cross/tar_generator.h (right):

http://codereview.chromium.org/159129/diff/1/3#newcode70
Line 70: virtual bool AddFile(const String &file_name,
add comment about return value

http://codereview.chromium.org/159129/diff/1/3#newcode82
Line 82: bool AddEntry(const String &file_name,
add comment about return value

http://codereview.chromium.org/159129/diff/1/3#newcode86
Line 86: bool AddDirectory(const String &file_name);
comment about return value

http://codereview.chromium.org/159129/diff/1/7
File import/cross/tar_processor.cc (right):

http://codereview.chromium.org/159129/diff/1/7#newcode66
Line 66: // The tar format stupidly represents size_teger values as
might as well fix this comment now "size_teger"