Refactor tar code to support long names....

import/cross/tar_processor_test.cc

 /*
  * Copyright 2009, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 24 matching lines @@
 #include "tests/common/win/testing_common.h"
 #include "tests/common/cross/test_utils.h"
 
 namespace o3d {
 
 class TarProcessorTest : public testing::Test {
 };
 
 // We verify that the tar file contains exactly these filenames
 static const char *kFilename1 = "test/file1";
-static const char *kFilename2 = "test/file2";
-static const char *kFilename3 = "test/file3";
+static const char *kFilename2 =
+    "test/file1ThisIsAFilenameLongerThen100Chars"
+    "ThisIsAFilenameLongerThen100Chars"
+    "ThisIsAFilenameLongerThen100CharsThisIsAFilenameLongerThen100Chars";
+static const char *kFilename3 = "test/file2";
+static const char *kFilename4 = "test/file3";
 
 // With each file having these exact contents
-#define kFileContents1 "the cat in the hat\n"
-#define kFileContents2 "abracadabra\n"
-#define kFileContents3 "I think therefore I am\n"
 
 // we should receive these (and exactly these bytes in this order)
 static const char *kConcatenatedContents =
-    kFileContents1  kFileContents2  kFileContents3;
+  "the cat in the hat\n"       // file 1 contents.
+  "this file has a long name"  // file 2 contents.
+  "abracadabra\n"              // file 3 contents.
+  "I think therefore I am\n"   // file 4 contents.
+  "";                          // end
 
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 class TarTestClient : public ArchiveCallbackClient {
  public:
   explicit TarTestClient() : file_count_(0), index_(0) {}
   // ArchiveCallbackClient methods
   virtual void ReceiveFileHeader(const ArchiveFileInfo &file_info);
   virtual bool ReceiveFileData(MemoryReadStream *stream, size_t nbytes);
 
   int GetFileCount() const { return file_count_; }
@@ skipping 12 matching lines @@
   switch (file_count_) {
     case 0:
       EXPECT_TRUE(!strcmp(kFilename1, file_info.GetFileName().c_str()));
       break;
     case 1:
       EXPECT_TRUE(!strcmp(kFilename2, file_info.GetFileName().c_str()));
       break;
     case 2:
       EXPECT_TRUE(!strcmp(kFilename3, file_info.GetFileName().c_str()));
       break;
+    case 3:
+      EXPECT_TRUE(!strcmp(kFilename4, file_info.GetFileName().c_str()));
+      break;
   }
 
   file_count_++;
 }
 
 // ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 bool TarTestClient::ReceiveFileData(MemoryReadStream *stream, size_t nbytes) {
   const char *p = reinterpret_cast<const char*>(
       stream->GetDirectMemoryPointer());
 
@@ skipping 44 matching lines @@
     result = tar_processor.ProcessBytes(&tar_stream, bytes_this_time);
     EXPECT_TRUE(result == Z_OK);
 
     bytes_to_process -= bytes_this_time;
   }
 
   free(tar_data);
 }
 
 }  // namespace