Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: statsreport/metrics_unittest.cc

Issue 159117: Delete bad sleep based tests... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/o3d/
Patch Set: Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: statsreport/metrics_unittest.cc
===================================================================
--- statsreport/metrics_unittest.cc (revision 21085)
+++ statsreport/metrics_unittest.cc (working copy)
@@ -211,19 +211,6 @@
// Should be precisely one sample in there
EXPECT_EQ(1, data.count);
- // Disable flaky tests on build server, unfortunately this reduces coverage
- // too, but it seems preferrable to breaking the build on a regular basis.
-#ifndef BUILD_SERVER_BUILD
- // Let's hope the scheduler doesn't leave us hanging more than 10 ms.
- EXPECT_GT(40, data.sum);
- // The sleep above seems to often terminate early on the build server,
- // I've observed captured times down to 18 ms, which is strange.
- // TODO: figure out whether the timer is broken or whether
- // sleep is breaking its promise, or whether e.g. we're getting different
- // walltimes on different CPUs due to BIOS bugs on the build server
- EXPECT_LT(15, data.sum);
-#endif
-
// again, this time with a non-unity count
{
TimingSample sample(&foo, 2);
@@ -237,14 +224,6 @@
// Should be precisely two samples in there
EXPECT_EQ(2, data.count);
- // Disable flaky tests on build server, unfortunately this reduces coverage
- // too, but it seems preferrable to breaking the build on a regular basis.
-#ifndef BUILD_SERVER_BUILD
- // Let's hope the scheduler doesn't leave us hanging more than 10 ms.
- EXPECT_GT(40, data.sum);
- EXPECT_LT(15, data.sum);
-#endif
-
// now with zero count
{
TimingSample sample(&foo, 0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698