Delete bad sleep based tests...

statsreport/metrics_unittest.cc

 /*
  * Copyright 2009, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 193 matching lines @@
     TimingSample sample(&foo);
 
     ::Sleep(30);
   }
 
   TimingMetric::TimingData data = foo.Reset();
 
   // Should be precisely one sample in there
   EXPECT_EQ(1, data.count);
 
-  // Disable flaky tests on build server, unfortunately this reduces coverage
-  // too, but it seems preferrable to breaking the build on a regular basis.
-#ifndef BUILD_SERVER_BUILD
-  // Let's hope the scheduler doesn't leave us hanging more than 10 ms.
-  EXPECT_GT(40, data.sum);
-  // The sleep above seems to often terminate early on the build server,
-  // I've observed captured times down to 18 ms, which is strange.
-  // TODO: figure out whether the timer is broken or whether
-  //    sleep is breaking its promise, or whether e.g. we're getting different
-  //    walltimes on different CPUs due to BIOS bugs on the build server
-  EXPECT_LT(15, data.sum);
-#endif
-
   // again, this time with a non-unity count
   {
     TimingSample sample(&foo, 2);
 
     EXPECT_EQ(2, sample.count());
     ::Sleep(30);
   }
 
   data = foo.Reset();
 
   // Should be precisely two samples in there
   EXPECT_EQ(2, data.count);
 
-  // Disable flaky tests on build server, unfortunately this reduces coverage
-  // too, but it seems preferrable to breaking the build on a regular basis.
-#ifndef BUILD_SERVER_BUILD
-  // Let's hope the scheduler doesn't leave us hanging more than 10 ms.
-  EXPECT_GT(40, data.sum);
-  EXPECT_LT(15, data.sum);
-#endif
-
   // now with zero count
   {
     TimingSample sample(&foo, 0);
   }
 
   data = foo.Reset();
 
   // Should be no samples in there
   EXPECT_EQ(0, data.count);
 }
@@ skipping 140 matching lines @@
   EXPECT_STREQ("bool_true", bool_true.name());
   EXPECT_TRUE(NULL == bool_true.next());
 
   const BoolMetric bool_false("bool_false", BoolMetric::kBoolFalse);
 
   EXPECT_EQ(BoolMetric::kBoolFalse, bool_false.value());
   EXPECT_EQ(kBoolType, bool_false.type());
   EXPECT_STREQ("bool_false", bool_false.name());
   EXPECT_TRUE(NULL == bool_false.next());
 }