Issue 159071: Change RegExpMacroAssemblerIA32::CaseInsensitiveCompareUC16 so that it...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 159071: Change RegExpMacroAssemblerIA32::CaseInsensitiveCompareUC16 so that it... (Closed)

Created:
11 years, 5 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen, Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Change RegExpMacroAssemblerIA32::CaseInsensitiveCompareUC16 so that it does not use stack-allocated character as a one-element character array. The use at this site was actually safe (Ecma262Canonicalize will only write to the first character of the array), but not obviously so. BUG=17103 Committed: http://code.google.com/p/v8/source/detail?r=2510

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	src/ia32/regexp-macro-assembler-ia32.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

11 years, 5 months ago (2009-07-20 19:47:39 UTC) #3

How does this patch make any difference?  If Ecma262Canonicalize  wrote to any
but the first character then this would be just as unsafe as the old version.

Expand Messages | Collapse Messages