src/ia32/regexp-macro-assembler-ia32.cc - Issue 159071: Change RegExpMacroAssemblerIA32::CaseInsensitiveCompareUC16 so that it...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/regexp-macro-assembler-ia32.cc

Issue 159071: Change RegExpMacroAssemblerIA32::CaseInsensitiveCompareUC16 so that it... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/regexp-macro-assembler-ia32.cc

===================================================================

--- src/ia32/regexp-macro-assembler-ia32.cc (revision 2508)

+++ src/ia32/regexp-macro-assembler-ia32.cc (working copy)

@@ -1073,10 +1073,12 @@

unibrow::uchar c1 = substring1[i];

unibrow::uchar c2 = substring2[i];

if (c1 != c2) {

- canonicalize.get(c1, '\0', &c1);

- if (c1 != c2) {

- canonicalize.get(c2, '\0', &c2);

- if (c1 != c2) {

+ unibrow::uchar s1[1] = { c1 };

+ canonicalize.get(c1, '\0', s1);

+ if (s1[0] != c2) {

+ unibrow::uchar s2[1] = { c2 };

+ canonicalize.get(c2, '\0', s2);

+ if (s1[0] != s2[0]) {

return 0;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »